Skip to content

Added action group for cms block duplication test #26540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2020
Merged

Added action group for cms block duplication test #26540

merged 1 commit into from
Feb 7, 2020

Conversation

ajithkumar-maragathavel
Copy link
Contributor

Description (*)

Added new action group for existing cms block duplication test and replace test action with action groups.

Questions or comments

The newly introduced action groups can be re-used for future tests.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@m2-assistant
Copy link

m2-assistant bot commented Jan 26, 2020

Hi @ajithkumar-maragathavel. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.
@magento-engcom-team magento-engcom-team added Partner: Ziffity partners-contribution Pull Request is created by Magento Partner labels Jan 26, 2020
lbajsarowicz
lbajsarowicz approved these changes Jan 26, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement!
@ghost ghost assigned lbajsarowicz Jan 26, 2020
@lbajsarowicz lbajsarowicz added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jan 26, 2020
@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-6688 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests
@engcom-Alfa engcom-Alfa self-assigned this Jan 27, 2020
@engcom-Alfa
Copy link
Contributor

QA not applicable
@engcom-Kilo engcom-Kilo self-assigned this Jan 27, 2020
@engcom-Kilo engcom-Kilo added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Jan 27, 2020
@ajithkumar-maragathavel
Copy link
Contributor Author

ajithkumar-maragathavel commented Feb 7, 2020 •
edited
Loading

@lbajsarowicz Unfortunately, I deleted my Magento 2 fork from my account accidentally.
So It is showing as unknown repository in the PR.

Please let me know if this PR can be merged or not.
I appreciate your help.

Thanks.
magento-engcom-team pushed a commit that referenced this pull request Feb 7, 2020
@slavvka
ENGCOM-6688: Added action group for cms block duplication test #26540
326d0d4
@magento-engcom-team magento-engcom-team merged commit 4e57571 into magento:2.4-develop Feb 7, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 7, 2020

Hi @ajithkumar-maragathavel, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Cms Partner: Ziffity partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4

5 participants

@ajithkumar-maragathavel @magento-engcom-team @engcom-Alfa @lbajsarowicz @engcom-Kilo