Skip to content

[Issue] [PHPMD] Add phpmd rule with ignoring of unused required parameters in the plugins #37914

@m2-assistant

Description

@m2-assistant

This issue is automatically created based on existing pull request: #33918: [PHPMD] Add phpmd rule with ignoring of unused required parameters in the plugins


Description (*)

This PR improve phpmd UnusedFormalParameter rule with ignoring of required unused parameters in the plugins.

  • around and after plugins has 2 required params $subject and $proceed (or $result for after plugin).
  • before plugin has 1 required param $subject.

This PR override standard UnusedFormalParameter rule and allow don't use @SuppressWarnings(PHPMD.UnusedFormalParameter) in the plugins.

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

  1. Configure phpmd
  2. Remove @SuppressWarnings(PHPMD.UnusedFormalParameter) from some plugin
  3. Add PluginInterface implementation into the class
  4. Run phpmd. Expected no UnusedFormalParameter errors

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Metadata

Metadata

Assignees

Labels

Area: FrameworkComponent: CatalogIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedPriority: P3May be fixed according to the position in the backlog.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchSeverity: S4Affects aesthetics, professional look and feel, “quality” or “usability”.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions