- Notifications
You must be signed in to change notification settings - Fork 9.4k
Closed
Labels
Area: FrameworkComponent: CatalogIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedPriority: P3May be fixed according to the position in the backlog.May be fixed according to the position in the backlog.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchThe issue has been reproduced on latest 2.4-develop branchSeverity: S4Affects aesthetics, professional look and feel, “quality” or “usability”.Affects aesthetics, professional look and feel, “quality” or “usability”.
Description
This issue is automatically created based on existing pull request: #33918: [PHPMD] Add phpmd rule with ignoring of unused required parameters in the plugins
Description (*)
This PR improve phpmd UnusedFormalParameter
rule with ignoring of required unused parameters in the plugins.
around
andafter
plugins has 2 required params$subject
and$proceed
(or$result
forafter
plugin).before
plugin has 1 required param$subject
.
This PR override standard UnusedFormalParameter
rule and allow don't use @SuppressWarnings(PHPMD.UnusedFormalParameter)
in the plugins.
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
- Configure phpmd
- Remove
@SuppressWarnings(PHPMD.UnusedFormalParameter)
from some plugin - Add
PluginInterface
implementation into the class - Run phpmd. Expected no
UnusedFormalParameter
errors
Questions or comments
Contribution checklist (*)
- Pull request has a meaningful description of its purpose
- All commits are accompanied by meaningful commit messages
- All new or changed code is covered with unit/integration tests (if applicable)
- README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
- All automated tests passed successfully (all builds are green)
Metadata
Metadata
Assignees
Labels
Area: FrameworkComponent: CatalogIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedPriority: P3May be fixed according to the position in the backlog.May be fixed according to the position in the backlog.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchThe issue has been reproduced on latest 2.4-develop branchSeverity: S4Affects aesthetics, professional look and feel, “quality” or “usability”.Affects aesthetics, professional look and feel, “quality” or “usability”.