- Notifications
You must be signed in to change notification settings - Fork 9.4k
Closed
Labels
Area: FrameworkComponent: TranslatePriority: P2A defect with this priority could have functionality issues which are not to expectations.A defect with this priority could have functionality issues which are not to expectations.Progress: doneReported on 2.4.xIndicates original Magento version for the Issue report.Indicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchThe issue has been reproduced on latest 2.4-develop branchTriage: Dev.ExperienceIssue related to Developer Experience and needs help with Triage to Confirm or Reject itIssue related to Developer Experience and needs help with Triage to Confirm or Reject itarea: localizationnon-issue
Description
Summary (*)
Examples (*)
Example this text italiano
se hai scelto il ritiro dell'usato, ricordati di preparare il vecchio prodotto scollegato e disinstallato
As you can see text contain one single quote
if we use translate attribute will not work. Same for data-bind
Change text (remove quote) will be workarounds but it's may not be option when sometimes we want keep remain text
Example
<span translate="'se hai scelto il ritiro dell'usato, ricordati di preparare il vecchio prodotto scollegato e disinstallato'"></span>
or
<span data-bind="i18n: 'se hai scelto il ritiro dell'usato, ricordati di preparare il vecchio prodotto scollegato e disinstallato'"></span>
Proposed solution
Additional Information
Steps to reproduce
- Add below line in
app/code/Magento/Checkout/view/frontend/web/template/onepage.html
:
<span data-bind="i18n: 'se hai scelto il ritiro dell'usato, ricordati di preparare il vecchio prodotto scollegato e disinstallato'"></span>
- Add translation in
app/code/Magento/Checkout/i18n/en_US.csv
- Check the checkout page, if we do not escape single quote, then there is an error in the console like below:
If we escape the single quote, we are not getting any error but the translation is not working, please have a look into the below screenshot:
Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.
- Severity: S0 - Affects critical data or functionality and leaves users with no workaround.
- Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
- Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
- Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
- Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Metadata
Metadata
Assignees
Labels
Area: FrameworkComponent: TranslatePriority: P2A defect with this priority could have functionality issues which are not to expectations.A defect with this priority could have functionality issues which are not to expectations.Progress: doneReported on 2.4.xIndicates original Magento version for the Issue report.Indicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchThe issue has been reproduced on latest 2.4-develop branchTriage: Dev.ExperienceIssue related to Developer Experience and needs help with Triage to Confirm or Reject itIssue related to Developer Experience and needs help with Triage to Confirm or Reject itarea: localizationnon-issue
Type
Projects
Status
Done