Add YouTube NoCookie Support

[sprankhub]

Description (*)

Adds support for youtube-nocookie.com domain.

Bug

#826

Fixed Issues (if relevant)

1. YouTube Nocookie URL Not Accepted #826: YouTube Nocookie URL Not Accepted

Builds

Manual testing scenarios (*)

See #826.

Questions or comments

Checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[BorisovskiP]

Tested and can confirm this patch does fix the issue.One thing to note is that in order for the youtube-no-cookie link to be loaded by pagebuilder, the Maximum Width must be specified. Otherwise the following error is thrown:

Temporarily allowed to save HTML value that contains restricted elements. Allowed HTML tags are: div, a, p, span, em, strong, ul, li, ol, h5, h4, h3, h2, h1, table, tbody, tr, td, th, tfoot, img, hr, figure, button, i, u, br, b, iframe, style, pre, svg, animate, animateMotion, animateTransform, circle, clipPath, defs, desc, ellipse, feBlend, feColorMatrix, feComponentTransfer, feComposite, feConvolveMatrix, feDiffuseLighting, feDisplacementMap, feDistantLight, feFlood, feFuncA, feFuncB, feFuncG, feFuncR, feGaussianBlur, feImage, feMerge, feMergeNode, feMorphology, feOffset, fePointLight, feSpecularLighting, feSpotLight, feTile, feTurbulence, filter, foreignObject, g, image, line, linearGradient, marker, mask, metadata, mpath, path, pattern, polygon, polyline, radialGradient, rect, set, stop, switch, symbol, text, textPath, title, tspan, use, view

[sprankhub]

Hmm indeed, unfortunately, it is a bit more involved than this :-/ I will try to work on a proper fix.

[bluemwhitew]

Another issue you'll most probably face is that Page Builder will revert back to using www.youtube.com when it reads the saved data and pre-populates the Video content type's fields.

For example, both https://www.youtube.com/watch?v=dQw4w9WgXcQ and https://youtu.be/dQw4w9WgXcQ (note the different domains) get converted to https://www.youtube.com/embed/dQw4w9WgXcQ when the data is read, meaning if the content is re-saved - even without changes - it'll go back to using the cookie-based domain.

[sprankhub]

With my latest changes, this should now work as expected. Mind testing, @bluemwhitew?

[paras89]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[sprankhub]

@bluemwhitew, mind testing the changes from this PR?

@paras89, I think the failing tests are unrelated to this PR...?

[sprankhub]

@paras89, would you be able to have a look at this PR?

[convenient]

I mistakenly approved this rather than 👍 , was on autopilot and too used to approving internal Ampersand PRs, whoops 😆

[bluemwhitew]

@sprankhub,

I would highly suggest adding (or extending) Magento Functional Testing Framework (MFTF) tests to support this changeset, which will make it easier to validate.

[sprankhub]

Thanks for the advice, @bluemwhitew. I value my time highly, though. If any Adobe official said "we'll merge this as soon as there is MFTF coverage", I'll consider implementing this. Until then, I save my time for more valuable tasks...

[sprankhub]

@sidolov, I feel bad for tagging you directly, but I currently do not know how else I could move this forward. Would you be able to move this forward?

[engcom-Hotel]

Hello @sprankhub,

I have reviewed the changes and it looks good to me. Can you please add some automated test for changes made in this PR?

We will move it further with this after the automated test has been added.

Thanks

[sprankhub]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[sprankhub]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[sprankhub]

@engcom-Hotel, I extended a fitting MFTF test. The failing WebAPI Tests look unrelated to me.

Could you have another look, please?

[engcom-Hotel]

@magento run WebAPI Tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Hotel]

Thanks @sprankhub for adding the automated test. I am approving this PR to process further.

[bluemwhitew]

Awesome job on this, @sprankhub! 🤘🏻

[engcom-Bravo]

Hi @sprankhub,

Thanks for the collaboration & contribution!

✔️ QA Passed

Preconditions:

• Install fresh Magento 2.4-develop and PHP 8.1

Manual testing scenario:

• Create CMS page.
• Use page builder to add content.
• Add video element. Enter https://www.youtube-nocookie.com/embed/019DMLEVkos as "Video URL".
• Click "Save" button.

Before: ✖️ 

After: ✔️  

[devarul]

This PR is in development by an internal team, it will be completed and delivered to the mainline according to our standards and processes. All the original community commits will be preserved.

[engcom-Hotel]

Thanks @devarul for the updates. We are moving this PR On Hold till that time.