[CMS Team 2 - Sprint 9] Maps Location, Stacked Buttons, and Button Test Coverage #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
- Added locations form and link it to map form - Updated map form - Added script to handle location logic - Added location listing converter
- Fixed less file
- Adding duplicate test for Button Group - Updating supporting selector and action group
- Adding no required fields test for Button Group
- Adding duplicate test for button item - Adding duplicate button item action group - Moving generic action groups to generic action group file - Changing <wait/> actions to <waitForPageLoad/> - Adding more data to ExternalLink - Updating fillSlideOutPanelLinkUrlField & validate keyword to use new ExternalLink entity - Updating affected tests for above change
- Removing accidentally checked in group
- Breaking button tests out into 2 files - Adding unique groups to each new button test file
- Fixing stories annotation
- Adding test for button item no required attributes
- Adding change button order test - Adding action groups for inline button editing and moving buttons - Adding supporting data and elements
- Adding test for moving button to another button group - Updating change button order test to be better - Adding supporting data
- Added validation rule mixins for custom location error messages - Created custom dynamic form grid template to allow clicks to open edit menu - Removed unused map marker converter - Updated preview logic to handle multi-location - Updated master template logic to handle multi-location - Updated controller to handle multi-location
- Removed extra space - Fixed minor docBlock issue
- Adding tests for different button text values - Adding supporting data
- Adding tests for different button type values - Adding supporting data
- Removed hidden id field from location form - Updated dynamic rows to rely on record_id to grab the correct map marker for edit
…ions - Updated converter to handle multi location - Updated documentation for the multi location - Updated integration test for multi location
- Moved dynamic rows to inside form/component - Updated accordion and map forms to reflect changes to folder structure - Added styling for dynamic rows - Updated grid template, configuration, and logic to add placeholder text in grid
- Fixed php code strict type declaration and docblock - Added location form to extend base form test ignore list - Fixed general docblock and whitespace issues
- Removed extra space
…ions - Updated map converter to check for % height and set it to default if found
- Adding action groups for Add Location button, form, and grid - Adding data for location phone number - Adding supporting selectors - Updating existing selectors to be unique - Updating tests to use changes
- Added state/region field to location - Updated templates to take the new state/region field - Removed extra spaces from grid template - Removed utility folder from linting blacklist - Fixed lint errors for util/map - Reverted shorthand function to longhand - Fixed text area for comment field in location form
- Fixing some location attribute tests - Updating action groups, data, elements
…ions - Added state field to location in master format document
…agento-obsessive-owls/magento2-page-builder into MAGETWO-88132-add-edit-location-to-map
- Fixing remaining map tests except ones that rely on lat/lng dom element in stage & storefront
- Moving test to different file and renaming a test name
- Renaming map test file name
- Updated locations listing converter to always parse float before saving to db
- remove validateVisualSelectOptionIsSelected action group and use existing one
- update duplicate test to use Stacked appearance
- Fallback to default stacking order in Button Item
- add test for button wrap with inline appearance
- Adding another location grid sorting test - Removing accidental group - Fixing step keys
- add translate to title
- Updated field name location_name to name - Fixed document white spacing - Updated lat and lng abbreviation to latitude and longitude
- Resolved name conflict for location form and map form
- Resolved issue with country failing to sort
- change selectors and data names
- Adding useCaseId annotation
- rename button data files
- Revert name to locaation_name
…for-buttons' into cms-team-2-sprint-9
- Fixed missed data scope location_name
…lignment-in-the-group' into cms-team-2-sprint-9
- Resolved data scoping issue and map utility reversion to location_name
…to-map' into cms-team-2-sprint-9
- Add strict type declaration to top of file
- Remove debugger statement - Reorder imports
- Resolved 'Add Pin Then Remove Then Add and Verify' test failure
- Update ButtomItem test to use correct Section and resolve issues with selectors - Update Buttons default test to work with new required Appearance
- Update Button Item tests to use shared/correct selectors
| Ran w/o MHI due to expected failure: https://jira.corp.magento.com/browse/MAGETWO-90019. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Scope
Story
Task
Bamboo CI Builds
Jenkins
Checklist