SVC Release 5.0.0 #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
* readme: Update README.md: Add information about releases and versioning
* EQPS-477: Dynamically set the correct path for autoload.php based on the location of the ‘vendor’ folder * EQPS-477: Make zend-stdlib a required dependency
Co-authored-by: Peter Dohogne <pdohogne@adobe.com>
Solving merge conflicts with master
- Added nikic/php-parser as hard dependency in composer - Improved performance of DependencyMap creation. - Remove stms when adding ClassMethod nodes to dependency tree - Added better doc comments - Addeed more aggresive AbstractApiVisitor traversal termination - Refactored code to use switch statements
roribio pushed a commit that referenced this pull request Jun 18, 2020
* SVC Release 5.0.0 (#32) * MC-30776: Improve Performance of SVC (#28) - Added nikic/php-parser as hard dependency in composer - Improved performance of DependencyMap creation. - Remove stms when adding ClassMethod nodes to dependency tree - Added better doc comments - Addeed more aggresive AbstractApiVisitor traversal termination - Refactored code to use switch statements Co-authored-by: Raoul Rego <raoulrego@gmail.com> * MC-33067: Update magento2-infrastructure composer dependencies - Add PHP 7.4 to composer.json * Update magento-semver to be compatible with PHP7.4 (#33) * MC-33156: Update magento-semver to be compatible with PHP7.4
magento-devops-reposync-svc pushed a commit that referenced this pull request Jun 22, 2022
…yrrans-magento-semver-69 [Imported] [Pyrrans] AC-3208: updated symfony/console to the latest version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description (*)
Add performance improvements to SVC during creation of DependencyMap and creation of static analyzers. I also remove the method stmts from the method nodes being stored in the dependency map. This is to fix the memory issues when comparing files.
- Added nikic/php-parser as hard dependency in composer
- Improved performance of DependencyMap creation.
- Remove stms when adding ClassMethod nodes to dependency tree
- Added better doc comments
- Addeed more aggresive AbstractApiVisitor traversal termination
- Refactored code to use switch statements
Fixed Issues (if relevant)
https://jira.corp.magento.com/browse/MC-30776
Manual testing scenarios (*)
Compared results with running original svc branch using 2.3-develop and 2.4-develop.
Both logs are equivalent. The only difference is that this branch adds some "Method implementation changed" PATCH changes. This is explained in AbstractApiVisitor::enterNode comment.
Questions or comments
Contribution checklist (*)