Fix DirectThrowSniff false positive #331
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ihor-sviziev requested changes Nov 30, 2021
| return [ | ||
| 20 => 1 | ||
| ]; | ||
| |
| | ||
| } | ||
| return []; | ||
| |
m2-community-project bot added Progress: changes requested and removed Progress: ready for review labels 
ihor-sviziev previously approved these changes Nov 30, 2021
svera suggested changes Dec 15, 2021
m2-community-project bot added Progress: changes requested and removed Progress: approved labels 
Co-authored-by: Sergio Vera <sergio.vera@gmail.com>
ihor-sviziev approved these changes Dec 16, 2021
m2-community-project bot added Progress: approved and removed Progress: changes requested labels svera approved these changes Dec 16, 2021
| @magento import pr to magento-commerce/magento-coding-standard |
| @svera the Pull Request is successfully imported. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description (*)
Fixed Issues (if relevant)