Added Constant visibility in the ruleset #330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ihor-sviziev previously approved these changes Nov 9, 2021
m2-community-project bot added Progress: approved and removed Progress: ready for review labels 
sivaschenko requested changes Nov 10, 2021
Member
sivaschenko left a comment
sivaschenko left a comment There was a problem hiding this comment.
Thanks for the improvement @rmsundar1 . Please take a look at my comment
m2-community-project bot added Progress: changes requested and removed Progress: approved labels 
m2-community-project bot added Progress: review and removed Progress: changes requested labels sivaschenko approved these changes Nov 15, 2021
Member
| @magento import pr to magento-commerce/magento-coding-standard |
Contributor
| @sivaschenko the Pull Request is successfully imported. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description (*)
Added Constant visibility check in the ruleset
Fixed Issues (if relevant)
constvisibility #174