Update rule names for better messaging #328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
sivaschenko approved these changes Nov 9, 2021
m2-community-project bot added Progress: approved and removed Progress: ready for review labels 
| @magento import pr to magento-commerce/magento-coding-standard |
| @sivaschenko the Pull Request is successfully imported. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There are a lot of different rules that are defined within
Magento2/Sniffs/Annotation/MethodArgumentsSniff.php. These all were reported as the same genericMagento2.Annotation.MethodArguments.MethodArguments; now these have a descriptive rule name, such asMagento2.Annotation.MethodArguments.ParamOrderorMagento2.Annotation.MethodArguments.ExtraParam.