Skip to content

AC-1549: Create codes for each type of returned error / warning #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 26, 2021
Merged

AC-1549: Create codes for each type of returned error / warning #316

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
1bd89ac
AC-1549: Create codes for each type of returned error / warning
svera Oct 26, 2021
c147628
AC-1549: Fixed static tests
svera Oct 26, 2021
94a395a
AC-1549: Added more codes and cleaned up unused messages
svera Oct 26, 2021
f76f48f
Update Magento2/Sniffs/Legacy/InstallUpgradeSniff.php
svera Oct 26, 2021
3953207
Update Magento2/Sniffs/Legacy/PhtmlTemplateSniff.php
svera Oct 26, 2021
28ce4ef
Update Magento2/Sniffs/Legacy/PhtmlTemplateSniff.php
svera Oct 26, 2021
d7c4374
Update Magento2/Sniffs/Legacy/PhtmlTemplateSniff.php
svera Oct 26, 2021
ee515c3
Update Magento2/Sniffs/Legacy/_files/restricted_classes.php
svera Oct 26, 2021
2391b0d
AC-1549: Made suggestions
svera Oct 26, 2021
852a479
AC-1549: Made suggestions
svera Oct 26, 2021
3d3dc9e
AC-1549: Made suggestions
svera Oct 26, 2021
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
AC-1549: Made suggestions
  • Loading branch information
@svera
svera committed Oct 26, 2021
commit 852a479d8a4ba28fe21d718672dee5934119ec2b
22 changes: 12 additions & 10 deletions Magento2/Sniffs/Legacy/ObsoleteConnectionSniff.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,18 @@ class ObsoleteConnectionSniff implements Sniff
* @var string[]
*/
private $obsoleteMethods = [
'_getReadConnection' => 'FoundObsoleteMethod_getReadConnection',
'_getWriteConnection' => 'FoundObsoleteMethod_getWriteConnection',
'_getReadAdapter' => 'FoundObsoleteMethod_getReadAdapter',
'_getWriteAdapter' => 'FoundObsoleteMethod_getWriteAdapter',
'getReadConnection' => 'FoundObsoleteMethodGetReadConnection',
'getWriteConnection' => 'FoundObsoleteMethodGetWriteConnection',
'getReadAdapter' => 'FoundObsoleteMethodGetReadAdapter',
'getWriteAdapter' => 'FoundObsoleteMethodGetWriteAdapter',
'_getReadConnection',
'_getWriteConnection',
'_getReadAdapter',
'_getWriteAdapter',
'getReadConnection',
'getWriteConnection',
'getReadAdapter',
'getWriteAdapter',
];

private const OBSOLETE_METHOD_ERROR_CODE = 'ObsoleteMethodFound';

/**
* @inheritdoc
*/
Expand Down Expand Up @@ -56,12 +58,12 @@ private function validateObsoleteMethod(File $phpcsFile, int $stackPtr)
$tokens = $phpcsFile->getTokens();
$stringPos = $phpcsFile->findNext(T_STRING, $stackPtr + 1);

foreach ($this->obsoleteMethods as $method => $errorCode) {
foreach ($this->obsoleteMethods as $method) {
if ($tokens[$stringPos]['content'] === $method) {
$phpcsFile->addWarning(
sprintf("Contains obsolete method: %s. Please use getConnection method instead.", $method),
$stackPtr,
$errorCode
self::OBSOLETE_METHOD_ERROR_CODE
);
}
}
Expand Down