Skip to content

Conversation

svera
Copy link
Contributor

@svera svera commented Oct 1, 2021

This sniff checks files for usages of restricted classes in there.

@svera svera marked this pull request as ready for review October 1, 2021 11:08
jcuerdo
jcuerdo previously approved these changes Oct 1, 2021
<rule ref="Magento2.Legacy.RestrictedCode">
<severity>10</severity>
<type>error</type>
<exclude-pattern>*\.xml$</exclude-pattern>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why only exclude xml?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcuerdo excluded also JS files

@svera
Copy link
Contributor Author

svera commented Oct 1, 2021

@magento import pr to magento-commerce/magento-coding-standard

@m2-github-services
Copy link
Contributor

@svera the Pull Request is successfully imported.

@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 082e6b8 into magento:develop Oct 1, 2021
@svera svera deleted the AC-682_restricted-code-sniff branch October 1, 2021 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

4 participants