AC-674: Create phpcs static check for ObsoleteAclTest #285
Conversation
| $xml = simplexml_load_string($this->getFormattedXML($phpcsFile)); | ||
| $foundElements = $xml->xpath('/config/acl/*[boolean(./children) or boolean(./title)]'); | ||
| foreach ($foundElements as $element) { | ||
| if (!$this->elementIsCurrentlySniffedLine($element, $stackPtr)) { |
There was a problem hiding this comment.
I think a better approach now is to return at the beginning of process id $stackPtr is not 0, this way, you'll only enter in the XML file once and won't need to use elementIsCurrentlySniffedLine. Take a look at WidgetXMLSniff.php
| <children default_policy="deny"/> | ||
| <acl> | ||
| <children> | ||
| <title value="foo"/> |
There was a problem hiding this comment.
Copy this file into a new one and put the attribute value in a new line, to check that it will get errors in weird formatted XML files
There was a problem hiding this comment.
I have added a new line inside the same file following your recommendation. I tested it and it works correctly as it matches the pattern provided.
m2-community-project bot added Progress: changes requested Progress: review and removed Progress: ready for review Progress: changes requested labels 
Magento2/ruleset.xml Outdated
| <type>warning</type> | ||
| </rule> | ||
| <rule ref="Magento2.Legacy.ObsoleteAcl"> | ||
| <include-pattern>*\/widget.xml$</include-pattern> |
There was a problem hiding this comment.
I think you should include the config.xml here.
m2-community-project bot added Progress: changes requested and removed Progress: approved labels 
m2-community-project bot added Progress: approved and removed Progress: changes requested labels 
| @magento import pr to magento-commerce/magento-coding-standard |
| @loginesta the Pull Request is successfully imported. |
6 participants
https://jira.corp.magento.com/browse/AC-674 Create phpcs static check for ObsoleteAclTest