AC-665: Create phpcs static check for ConfigTest #278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jcuerdo suggested changes Sep 22, 2021
| <severity>10</severity> | ||
| <type>error</type> | ||
| </rule> | ||
| <rule ref="Magento2.Legacy.ObsoleteConfigNodes"> |
There was a problem hiding this comment.
I think the correct name is "ObsoleteNodeInConfig"
There was a problem hiding this comment.
@jcuerdo this is referring a to nodes specific to config, so it's also correct to call them this way. Also, old rule is called also config nodes.
m2-community-project bot added Progress: changes requested Progress: review and removed Progress: ready for review Progress: changes requested labels 
eliseacornejo approved these changes Sep 22, 2021
jcuerdo approved these changes Sep 22, 2021
jcuerdo approved these changes Sep 22, 2021
| @magento import pr to magento-commerce/magento-coding-standard |
| @svera the Pull Request is successfully imported. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This sniff will check
config.xmlfiles looking for obsolete nodes occurrences in them, usingMagento2/Sniffs/Legacy/_files/obsolete_config_nodes.phpas reference.