Skip to content

AC-661: Create phpcs static check for XmlTest #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 13, 2021
Merged

AC-661: Create phpcs static check for XmlTest #266

merged 9 commits into from
Sep 13, 2021

Conversation

jcuerdo
Copy link
Contributor

@jcuerdo jcuerdo commented Sep 9, 2021 •
edited
Loading

\Magento\Test\Legacy\Magento\Widget\XmlTest test for backwards-incompatible change in widget.xml structure
svera
svera suggested changes Sep 9, 2021
View reviewed changes
svera
svera suggested changes Sep 9, 2021
View reviewed changes
@svera
Copy link
Contributor

svera commented Sep 9, 2021

Also provide a description for the PR
loginesta
loginesta reviewed Sep 9, 2021
View reviewed changes
Copy link
Contributor

@loginesta loginesta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can run the following in advance vendor/bin/phpcs --standard=Magento2 Magento2/Helpers/ Magento2/Sniffs, prior to pushing changes to your PR
@jcuerdo jcuerdo requested review from loginesta and svera September 9, 2021 14:33
svera
svera suggested changes Sep 9, 2021
View reviewed changes
Copy link
Contributor

@svera svera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This case is still missing, I was referring to badly formatted XML file, not wrong XML:

Include another file like this, but having the translate attribute in a new line to check also badly formatted XML files
loginesta
loginesta previously approved these changes Sep 9, 2021
View reviewed changes
svera
svera reviewed Sep 13, 2021
View reviewed changes
@jcuerdo
Copy link
Contributor Author

jcuerdo commented Sep 13, 2021

@magento import pr to magento-commerce/magento-coding-standard
@magento-engcom-team
Copy link
Contributor

@jcuerdo the pull request successfully imported.
@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 9b4da0c into magento:develop Sep 13, 2021
@jcuerdo jcuerdo deleted the AC-661 branch September 13, 2021 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Progress: done

5 participants

@jcuerdo @svera @magento-engcom-team @loginesta @magento-devops-reposync-svc