AC-667: Create phpcs static check for EmailTemplateTest #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
loginesta reviewed Sep 7, 2021
| <h1>{{htmlescape "H1"}}</h1> | ||
| <h2>{{escapehtml "H2"}}</h2> | ||
| <p>{{escapehtml "p"}} {{htmlescape "p"}}</p> | ||
| <p class="greeting">{{trans "Translateme"}}</p> No newline at end of file |
There was a problem hiding this comment.
no new line at the end of file
m2-community-project bot added Progress: review and removed Progress: ready for review labels 
sivaschenko requested changes Sep 7, 2021
There was a problem hiding this comment.
Great first contribution, @jcuerdo ! Please see my comments
| <severity>8</severity> | ||
| <type>warning</type> | ||
| </rule> | ||
| |
There was a problem hiding this comment.
I'd remove this empty line for consistency.
Magento2/ruleset.xml Outdated
| <include-pattern>view/email/*.html</include-pattern> | ||
| <include-pattern>view/*/email/*.html</include-pattern> | ||
| <severity>8</severity> | ||
| <type>warning</type> |
There was a problem hiding this comment.
I think this should be an error as using of obsolete directives will actually break the functionality of email templates
m2-community-project bot added Progress: changes requested and removed Progress: review labels 
svera previously approved these changes Sep 7, 2021
m2-community-project bot added Progress: approved and removed Progress: changes requested labels sivaschenko reviewed Sep 7, 2021
Co-authored-by: Sergii Ivashchenko <serg.ivashchenko@gmail.com>
sivaschenko approved these changes Sep 8, 2021
| @magento import pr to magento-commerce/magento-coding-standard |
| @jcuerdo the pull request successfully imported. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.