Create phpcs static check for DiConfigTest #233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
- DiConfigTest: Test for obsolete nodes in di.xml
sivaschenko changed the title 
sivaschenko requested changes Aug 25, 2021
There was a problem hiding this comment.
Thanks for the pull request @loginesta ! Can you please verify the test functionality running it against the Magento code with changed di.xml files?
m2-community-project bot added Progress: changes requested and removed Progress: ready for review labels 
svera reviewed Aug 25, 2021
m2-community-project bot added Progress: review and removed Progress: changes requested labels - Add missing composer.lock
Co-authored-by: Sergii Ivashchenko <serg.ivashchenko@gmail.com>
- Run composer update --lock
- Fix return type
- Update XML files
- Refactor: Simplify approach
sivaschenko requested changes Aug 27, 2021
| { | ||
| private const WARNING_CODE = 'FoundObsoleteAttribute'; | ||
| | ||
| private $xpathObsoleteElems = [ |
There was a problem hiding this comment.
I would renamve this property as it's not xpath anymore, also it would be good to add a phpdoc
Suggested change
| private $xpathObsoleteElems = [ | |
| private $obsoleteDiNodes = [ |
| { | ||
| $lineContent = $phpcsFile->getTokensAsString($stackPtr, 1); | ||
| | ||
| foreach ($this->xpathObsoleteElems as $elem => $message) { |
There was a problem hiding this comment.
It's a good pratice to use whole words for variables naming
Suggested change
| foreach ($this->xpathObsoleteElems as $elem => $message) { | |
| foreach ($this->xpathObsoleteElems as $element => $message) { |
m2-community-project bot added Progress: changes requested and removed Progress: review labels - Refactor: Rename variables and add phpdoc
sivaschenko approved these changes Aug 30, 2021
m2-community-project bot added Progress: approved and removed Progress: changes requested labels 
| @magento import pr to magento-commerce/magento-coding-standard |
| @sivaschenko the pull request successfully imported. |
svera approved these changes Aug 30, 2021
magento-devops-reposync-svc pushed a commit that referenced this pull request Aug 9, 2023
…o-coding-standard-453 [Imported] Update supported PHP versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This sniffer looks for occurrences of obsolete nodes:
param,instance,array,item[@key]andvalue.Returns a warning for each occurrence found.
https://jira.corp.magento.com/browse/AC-660