AC-601: Create phpcs static check for AbstractBlockTest #218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
sivaschenko requested changes Aug 19, 2021
There was a problem hiding this comment.
Thanks for the pull request @eliseacornejo ! Please see my comments
m2-community-project bot added Progress: changes requested and removed Progress: ready for review labels m2-community-project bot added Progress: review and removed Progress: changes requested labels sivaschenko reviewed Aug 19, 2021
sivaschenko approved these changes Aug 19, 2021
| @magento import pr to magento-commerce/magento-coding-standard |
| @sivaschenko the pull request successfully imported. |
magento-devops-reposync-svc pushed a commit that referenced this pull request May 15, 2023
ACP2E-1946: Move PHPCompatibility/PHPCompatibility sniffs into separate namespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
AC-601: Create phpcs static check for AbstractBlockTest
This PR is to start moving the legacy static checks we have on Magento2 codebase. This is covering the AbstractBlock changes.