Skip to content

#147 - Fixed include / exclude patterns in ruleset.xml #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 13, 2020
Merged

#147 - Fixed include / exclude patterns in ruleset.xml #180

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4cbc97
#147 - Fixed include / exclude patterns in ruleset.xml
sinisa86 Apr 4, 2020
2ce0536
Merge branch 'develop' into ticket-147
lenaorobei Apr 7, 2020
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions Magento2/ruleset.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<rule ref="Generic.PHP.CharacterBeforePHPOpeningTag">
<severity>10</severity>
<type>error</type>
<exclude-pattern>*.phtml</exclude-pattern>
<exclude-pattern>*\.phtml$</exclude-pattern>
</rule>
<rule ref="Generic.PHP.DeprecatedFunctions">
<severity>10</severity>
Expand Down Expand Up @@ -76,7 +76,7 @@
<type>error</type>
</rule>
<rule ref="Magento2.Security.LanguageConstruct.DirectOutput">
<exclude-pattern>*.phtml</exclude-pattern>
<exclude-pattern>*\.phtml$</exclude-pattern>
</rule>
<rule ref="Magento2.Security.Superglobal.SuperglobalUsageError">
<severity>10</severity>
Expand All @@ -99,7 +99,7 @@
<rule ref="PSR2.Files.ClosingTag">
<severity>10</severity>
<type>error</type>
<exclude-pattern>*.phtml</exclude-pattern>
<exclude-pattern>*\.phtml$</exclude-pattern>
</rule>
<rule ref="Squiz.PHP.Eval">
<severity>10</severity>
Expand All @@ -122,7 +122,7 @@
<exclude-pattern>*/tests/*</exclude-pattern>
</rule>
<rule ref="Magento2.Security.XssTemplate">
<include-pattern>*.phtml</include-pattern>
<include-pattern>*\.phtml$</include-pattern>
<severity>9</severity>
<type>warning</type>
</rule>
Expand Down Expand Up @@ -207,7 +207,7 @@
<type>warning</type>
</rule>
<rule ref="Magento2.Templates.ThisInTemplate">
<include-pattern>*.phtml</include-pattern>
<include-pattern>*\.phtml$</include-pattern>
<severity>8</severity>
<type>warning</type>
</rule>
Expand Down Expand Up @@ -302,7 +302,7 @@
<rule ref="Squiz.Operators.IncrementDecrementUsage">
<severity>7</severity>
<type>warning</type>
<exclude-pattern>*.phtml</exclude-pattern>
<exclude-pattern>*\.phtml$</exclude-pattern>
</rule>
<rule ref="Squiz.Operators.ValidLogicalOperators">
<severity>7</severity>
Expand Down Expand Up @@ -404,7 +404,7 @@
<rule ref="PEAR.ControlStructures.ControlSignature">
<severity>6</severity>
<type>warning</type>
<exclude-pattern>*.phtml</exclude-pattern>
<exclude-pattern>*\.phtml$</exclude-pattern>
</rule>
<rule ref="PSR1.Files.SideEffects">
<severity>6</severity>
Expand Down Expand Up @@ -483,7 +483,7 @@
</properties>
</rule>
<rule ref="Squiz.ControlStructures.ControlSignature.NewlineAfterOpenBrace">
<exclude-pattern>*.phtml</exclude-pattern>
<exclude-pattern>*\.phtml$</exclude-pattern>
</rule>
<rule ref="Squiz.ControlStructures.ForEachLoopDeclaration">
<severity>6</severity>
Expand Down Expand Up @@ -533,7 +533,7 @@
<rule ref="Squiz.WhiteSpace.ScopeClosingBrace">
<severity>6</severity>
<type>warning</type>
<exclude-pattern>*.phtml</exclude-pattern>
<exclude-pattern>*\.phtml$</exclude-pattern>
</rule>
<rule ref="Squiz.WhiteSpace.ScopeKeywordSpacing">
<severity>6</severity>
Expand Down