Skip to content

Feature/improve vcl backend response #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
toonvd wants to merge 3 commits into
base: 2.4-develop
Choose a base branch
from
Open

Feature/improve vcl backend response #70

toonvd wants to merge 3 commits into from

Conversation

@toonvd
Copy link

@toonvd toonvd commented Dec 9, 2023

Description

This PR is a rework of the Magento VCL (the vcl_backend_response part) PR found here:
https://github.com/magento/magento2/pull/36796/files

All credits go to @peterjaap and @ThijsFeryn, I am simpling slicing this up and removing controversial parts to get early approval.

Related Pull Requests

#62
#69

Manual testing scenarios

  • Load the new VCL
  • Test if cacheable content is still cached

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@toonvd toonvd requested a review from a team as a code owner December 9, 2023 21:08
This was referenced Dec 9, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@toonvd