Change customer save before observer to listen for "customer_save_before" event #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ore" event instead of the non-existent "customer_save_commit_before"
Member
| hi @aligent-lturner, would it be possible to rename the branch to have the prefix |
Contributor Author
I can change it, though it's probably a good idea to have tests run on |
Contributor Author
| Replaced with #25 with different branch name |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #23
The current implementation is listening for the "customer_save_commit_before" event, but this event does not exist in the core Magento implementation. Instead, it should be listening to the "customer_save_before" event.
This will ensure that customers with changed data get flagged as having been updated properly.