Skip to content

Conversation

@avstudnitz
Copy link
Contributor

No description provided.

@avstudnitz avstudnitz requested review from a team as code owners September 17, 2024 12:48
Copy link
Member

@gowrizrh gowrizrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple questions

@avstudnitz avstudnitz requested a review from gowrizrh September 18, 2024 06:20
Copy link
Member

@gowrizrh gowrizrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this prevent order updates from propogating through? If the order is new and is saved in the registry and the next time the order is updated becase it's paid or status updated then this effectively would block it because the code sees it as it's already processed right?

I've approved but you may want to test those cases to see if it's working as intended for you.

@avstudnitz
Copy link
Contributor Author

Wouldn't this prevent order updates from propogating through? If the order is new and is saved in the registry and the next time the order is updated becase it's paid or status updated then this effectively would block it because the code sees it as it's already processed right?

I've approved but you may want to test those cases to see if it's working as intended for you.

@gowrizrh That would be in a different request then - the registry is cleared after each request and not persistant. In theory, several changes to an order could happen in a single request, but that would be very unusual (and also wouldn't make much sense IMO).

@avstudnitz avstudnitz merged commit e4e59bf into mage-os:main Sep 18, 2024
@gowrizrh
Copy link
Member

makes sense 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants