Fix(sales): Fix observers for sales order and shipment #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
In both cases the increment_id was written to the queue, although the entity_id was needed for the supplied consumers.
avstudnitz approved these changes Jul 11, 2024
Contributor
avstudnitz left a comment
avstudnitz left a comment There was a problem hiding this comment.
@nhp Thanks!
Would you agree that we have the same problem with ceditmemos and invoices?
Contributor
| Strange, I am pretty sure that I tested these events when I implemented them... |
gowrizrh approved these changes Jul 12, 2024
Member
| i had a quick look and i'm feeling that might be the case as both creditmemos and invoices use the increment id while the repositories expect the entity id? if you'd like to update that that'd be great, thanks! |
gowrizrh approved these changes Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
In both cases the increment_id was written to the queue, although the entity_id was needed for the supplied consumers.