Skip to content

Conversation

@aslatter
Copy link
Contributor

This updates JavaScriptPrettier to the current release of prettier.

This is un-tested - I was going to let your setup of AppVeyor do the build for me (it looks like it will build pull-requests?). I'll update this PR once I've tried out the vsix.

@aslatter
Copy link
Contributor Author

The built vsix works for me.

@DarkCow
Copy link

DarkCow commented Apr 2, 2018

the built vsix works for me too. Thanks

edit: needed it for the fragment syntax support <> </>

@jesperbjensen
Copy link
Collaborator

Hi @aslatter

I'm helping Mads maintain the repo, so we can get som releases and bug fixes out. Do you see any problems if we instead upgrade to the latest version? (1.12.1)

If not - then can you update your pull request to point to that version? (Or else I'm afraid that you will loose your contributor badge)

If you see a problem using that version - we will just merge your pull request for now. I'm thinking that we need to look into some way that you can control the version of prettier - or as a #16 points out - a way to control it using your package.json file. But we need to get a better version of prettier out soon - as the one bundled in the release version is way to old.

@aslatter
Copy link
Contributor Author

aslatter commented May 15, 2018

I'm okay with 1.12.1. I won't be able to update the PR until this evening - if you move quicker than that it's fine with me.

edit: "this evening" in UTC -5, that is

@aslatter aslatter changed the title Updated Prettier to version 1.11.1 Update Prettier to version 1.12.1 May 16, 2018
@jesperbjensen jesperbjensen merged commit a34f41d into madskristensen:master May 16, 2018
@jesperbjensen
Copy link
Collaborator

@aslatter Thank you 😄

To get the extension build from the master branch - you can get it here: http://vsixgallery.com/extension/J1da7ad9e-85b3-4a0c-8e45-b2ae59a575a7/

I will ask Mads to make a new public release - when I have tried the new version a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants