Skip to content

Conversation

@jesperbjensen
Copy link
Collaborator

@jesperbjensen jesperbjensen commented Dec 1, 2017

Prettier has a --stdin-filepath argument that works wonders:

  1. It selects the correct parser according to the filename - so TypeScript works alot better.
  2. It looks for Prettier configuration files according to their configuration pattern. So people can use the configuration file that the VSCode extension uses and such.

I have also removed the Visual Studio formatting after the Prettier command. I'm not sure if you like that change - but it can be very confusing if you change the default tab size, and then Visual Studio goes in and reverts that to it's own formatting. We can add it back in if you like.

This matched with Pull Request #14 should fix:

#12
#8
#4

But I haven't had time to really test each of them.

@madskristensen madskristensen merged commit 8b046c2 into madskristensen:master Dec 1, 2017
@madskristensen
Copy link
Owner

Awesome. Thanks

@madskristensen
Copy link
Owner

@achebrol achebrol mentioned this pull request Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants