Skip to content

remove Arduino.h include #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
madhephaestus merged 2 commits into from
Jul 27, 2022
Merged

remove Arduino.h include #65

madhephaestus merged 2 commits into from
Jul 27, 2022

Conversation

@guidoschreuder
Copy link
Contributor

@guidoschreuder guidoschreuder commented Jul 18, 2022

Resolves #64
@madhephaestus
Copy link
Owner

madhephaestus commented Jul 26, 2022

if the prototype of the header changed, don't you need to also change the prototype of the CPP implementation also?
@madhephaestus
Copy link
Owner

madhephaestus commented Jul 26, 2022

looks like this needs an update after upstream merges
@guidoschreuder
Copy link
Contributor Author

guidoschreuder commented Jul 26, 2022

if the prototype of the header changed, don't you need to also change the prototype of the CPP implementation also?

You had me puzzled for a second, but the implementation is inline with the declaration:
boolean isAttached(){return attached;}

There is no other occurrence of boolean

Resolved the conflicts
@madhephaestus madhephaestus merged commit a9d6a22 into madhephaestus:master Jul 27, 2022
@guidoschreuder guidoschreuder deleted the remove-arduino-dependency branch July 30, 2022 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@guidoschreuder @madhephaestus