Skip to content

fix(logo): remove margin ngx-signal-state logo #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2023
Merged

fix(logo): remove margin ngx-signal-state logo #128

merged 1 commit into from
Oct 28, 2023

Conversation

@maartentibau
Copy link
Owner

@maartentibau maartentibau commented Oct 27, 2023

Checklist for logo submission

  • Logo file added to the logos folder
  • Created a new entry in metadata.json (only name is mandatory)
  • Logo is an SVG with vector paths (no embedded pixel image)
  • The logo fills the image and there is no white margin (please remove the white margin if there is any 🙂 )
@maartentibau maartentibau requested a review from fmalcher October 27, 2023 12:56
@maartentibau
Copy link
Owner Author

maartentibau commented Oct 27, 2023

@fmalcher Does this make it better? I adjusted the viewbox to just make it fit the logo.
@fmalcher
Copy link
Collaborator

fmalcher commented Oct 28, 2023

@maartentibau Yes! 🙂
@maartentibau maartentibau merged commit e171a1b into master Oct 28, 2023
@fmalcher fmalcher deleted the chore/add-ngx-signal-state branch October 28, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@maartentibau @fmalcher