Fixes for the ESP32 S3 build #263
Conversation
| I made some comments on the changes that are proposed. I had made changes before I realized that I had forgotten to add the source file to the cmake script which was what was causing some of the issues. I couldn't understand why there were some of the issues and once I found out what the issue were being caused by I did not revert any of the changes I made as sleep was more important at the time. |
| Oh sorry, I've just noticed that by the time I've created the pull-request you've already started fixing those issues. Sorry for the confusion. You can close this PR if you want. |
| No No. correct those couple of things and I will merge it because I do want to revert some of it back to the way it was originally. You spent the time to do the work I basically didn't want to do. LOL. Just need to update a few things so it can be merged. |
No problem, but I don't see any comments in the code review, where are they? |
| I was also messing around with the CI when I was making the changes I was making... It was taking too damned long for the CI to run. I changed it so instead of it using GitHub's servers for the CI it is using my server to run the CI. It is now able to run the builds in 4 minutes when it was taking 14 minutes to complete. |
lukier force-pushed the fix-for-esp32-s3 branch from 1f5209a to 4e5b545 Compare | It's running the CI now. |
2 participants
I couldn't build for ESP32-S3 last night, so I fixed the code in a couple of places.