o_char and e_char are always empty, then returncode is None #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
by line 282 o_char and e_char are always empty since `while o_char != b'':` and `while e_char != b'':` will have done their job
o_char and e_char are always empty, then returncode is None
| I am actually going to be redoing how the subprocesses are handled. It's turned into a monster is what it has done and I need to clean it up. Parsing subprocess output can be a royal pain to do especially when the process needs to run for a long time which is the case here. |
| I fixed the build. I wrote the spawn function over again. It has a smaller code footprint now and it should have less of an issue working. |
| build for esp32 (on WSL-ubuntu) works again |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
by line 282
o_charande_charare always emptysince
while o_char != b'':andwhile e_char != b'':will have done their jobwhen this
breakis executed, it might be thatp.poll()has not yet filled in the returncodeThis might result in all kind of strange behavior if the result of
spawnis checked and found to beNonein stead of0Same concern for the break for prompt.
Maybe after
o_buf = read()a call should be addedp.wait()to ensure the child process has terminated?