Fix off-by-one error in year builder. #230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Damn. Thanks! I'll try to add a regression test, get around to dealing with a few other open issues, and get this out sometime soon-ish. (Unfortunately, I've neglected my OSS work lately.) |
| No problem. Glad I could help. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This bug bit me when I was stress-testing some event-generation code at my job. Before fixing this bug, I was getting this result:
ghci λ: toField (fromGregorian 10000 1 1)Plain "':000-01-01'"After the fix, it works like this:
ghci λ: toField (fromGregorian 10000 1 1)Plain "'10000-01-01'"