Skip to content

fix: Connection terminated unexpectedly error not caught in on error handler #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2025
Merged

fix: Connection terminated unexpectedly error not caught in on error handler #783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions lib/postgresql.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,11 +103,19 @@ function PostgreSQL(postgresql, settings) {
function attachErrorHandler(settings, pg) {
if (settings.onError) {
if (settings.onError === 'ignore') {
pg.on('error', function(err) {
debug(err);
});
// Check if the error handler is already attached
// to avoid possible memory leak
if (!pg.listenerCount('error')) {
pg.on('error', function(err) {
debug(err);
});
}
} else {
pg.on('error', settings.onError);
// Check if the error handler is already attached
// to avoid possible memory leak
if (!pg.listenerCount('error')) {
pg.on('error', settings.onError);
}
}
}
}
Expand Down Expand Up @@ -165,8 +173,6 @@ PostgreSQL.prototype.executeSQL = function(sql, params, options, callback) {
// Release the connection back to the pool.
if (releaseCb) {
releaseCb(err);
// Remove error event listener to avoid possible memory leak
connection.removeAllListeners('error');
}
let result = null;
if (data) {
Expand Down
Loading