Skip to content

Update .travis.yml #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2020
Merged

Update .travis.yml #450

merged 1 commit into from
Aug 7, 2020

Conversation

@karanssj4
Copy link
Contributor

@karanssj4 karanssj4 commented Jun 23, 2020

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Commit messages are following our guidelines
@slnode
Copy link

slnode commented Jun 23, 2020

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."
@dhmlau
Copy link
Member

dhmlau commented Jun 29, 2020

@slnode test please
@dhmlau dhmlau added the community-contribution Patches contributed by community label Jun 29, 2020
@jannyHou jannyHou marked this pull request as ready for review June 30, 2020 02:15
@jannyHou
Copy link
Contributor

jannyHou commented Jun 30, 2020

Thanks @karanssj4 Some tests don't run probably due to the draft status, this change looks reasonable to me, so I changed it to "ready for review".

Let me trigger a test again.
@jannyHou
Copy link
Contributor

jannyHou commented Jun 30, 2020

@slnode test please
@jannyHou jannyHou mentioned this pull request Jun 30, 2020
Closed
4 tasks
@dhmlau
Copy link
Member

dhmlau commented Jul 28, 2020

Related to: loopbackio/loopback-next#6020
@dhmlau dhmlau self-assigned this Jul 28, 2020
@dhmlau
Copy link
Member

dhmlau commented Jul 28, 2020

@slnode test please
1 similar comment
@dhmlau
Copy link
Member

dhmlau commented Aug 4, 2020

@slnode test please
@dhmlau
Copy link
Member

dhmlau commented Aug 7, 2020

CI on Travis (with various Node.js versions) are passing. The pending check is stuck because the machine is no longer available. I suggest to force merge this PR.
jannyHou
jannyHou approved these changes Aug 7, 2020
View reviewed changes
Copy link
Contributor

@jannyHou jannyHou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with force merging it cc @dhmlau
@dhmlau dhmlau merged commit efc99b5 into loopbackio:master Aug 7, 2020
@dhmlau
Copy link
Member

dhmlau commented Aug 7, 2020

@karanssj4, thanks for your contribution. Your PR has landed! 🎉
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution Patches contributed by community

4 participants

@karanssj4 @slnode @dhmlau @jannyHou