[SEMVER-MAJOR]: upgrade dependencies #432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
- async to ^3.2 - chalk to ^4.0 - uuid to ^7.0 Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
Notable breaking changes: - Change default behavior when not specifying `rejectUnauthorized` with the SSL connection parameters. Previously we defaulted to `rejectUnauthorized: false` when it was not specifically included. We now default to `rejectUnauthorized: true`. Manually specify `{ ssl: { rejectUnauthorized: false } }` for old behavior. - Change default database when not specified to use the `user` config option if available. Previously `process.env.USER` was used. See pg's changelog for the full list of breaking changes. https://github.com/brianc/node-postgres/blob/master/CHANGELOG.md#pg800 Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com> - mocha to ^7.1 - sinon to ^9.0 Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
jannyHou approved these changes Apr 17, 2020
Contributor
jannyHou left a comment
jannyHou left a comment There was a problem hiding this comment.
Good catch for the breaking change, LGTM 👍
dhmlau approved these changes Apr 17, 2020
emonddr approved these changes Apr 17, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Update dependencies
Upgrade dev dependencies
[SEMVER-MAJOR] Upgrade
pgto8.0Notable breaking changes:
Change default behavior when not specifying
rejectUnauthorizedwith the SSL connection parameters. Previously we defaulted torejectUnauthorized: falsewhen it was not specifically included. We now default torejectUnauthorized: true. Manually specify{ ssl: { rejectUnauthorized: false } }for old behavior.Change default database when not specified to use the
userconfig option if available. Previouslyprocess.env.USERwas used.See pg's changelog for the full list of breaking changes.
https://github.com/brianc/node-postgres/blob/master/CHANGELOG.md#pg800
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machine