fix Postgres random CI failure #416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
agnes512 force-pushed the fix-ci branch 8 times, most recently from c11dfbe to a3548fc Compare agnes512 force-pushed the fix-ci branch 3 times, most recently from 7725b53 to aa9cee6 Compare 
emonddr approved these changes Feb 25, 2020
jannyHou reviewed Feb 26, 2020
Contributor
jannyHou left a comment
jannyHou left a comment There was a problem hiding this comment.
👏 great effort! the test flow is very clear now.
For the new tests:
Model Order has a foreign key customerId refers Model C2
-(autoupdate)->
Model Order has a fk productId refers to Model Product
-(autoupdate)->
Model Order doesn't have any fks.
I could see it tests add and remove, wondering how it test the update? I mean updating the existing fk.
| } | ||
| | ||
| // do initial update/creation of table with fk | ||
| ds.createModel(product_schema.name, product_schema.properties, product_schema.options); |
Contributor
There was a problem hiding this comment.
Thank you for providing the test flow, it's very helpful for reviewer. Could you also include it in the code comment?
Like IIUC here should be:
Model Order has a foreign key customerId refers Model C2
Initial update/creation of table with fk
nabdelgadir approved these changes Feb 27, 2020
Contributor Author
| @slnode test please |
1 similar comment
Contributor Author
| @slnode test please |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Connects to loopbackio/loopback-datasource-juggler#1816
After investigating, the random CI failures are caused when running autoupdate, the race condition might cause the problem.
OR
It failed to drop table (
customer_test2for example) while doing autouodate, so that it failed to updatecustomer_test2because the relation still exists.I've simplified the test case to avoid the second situation:
Before:
Model
Orderhas a foreign keycustomerIdrefers ModelC2-(autoupdate)->
Model
Orderhas a foreign keycustomerIdrefers ModelC3-(autoupdate)->
Model
Orderhas fkcustomerIdrefers ModelC2and fkproductIdrefers to ModelProduct-(autoupdate)->
Model
Orderdoesn't have any fks.Simplified
Model
Orderhas created a foreign keycustomerIdrefers ModelC2-(autoupdate)->
Model
Orderhas being updated to have a fkproductIdrefers to ModelProduct-(autoupdate)->
Model
Orderremoved all fks.I think the simplified one also checks that it should create, update, and delete foreign keys.
Please review it with whitespace hided
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machine