stop execution if rollback is called #330
Conversation
sahilarora946 requested review from b-admike, dhmlau, jannyHou, virkt25 and zbarbuto as code owners 
| Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
| @slnode test please |
| @zbarbuto why are these tests failing? |
| Unfortunately I don't have permission to view the CI. Will have to wait for one of the admins to have a look. cc @raymondfeng , @dhmlau , @b-admike could one of you possibly take it from here? |
| @slnode test please |
| @zbarbuto , sorry about the late reply. There was an CI issue that we ran into before. I thought it's been fixed. Let me kick off CI again to check. |
| CI all passed. |
sahilarora946 force-pushed the stop-execution-of-query-after-rollback branch from e4b5eaf to 8e5314c Compare stop execution if rollback is called stop execution if rollback is called
sahilarora946 force-pushed the stop-execution-of-query-after-rollback branch from 8e5314c to 8a06ce8 Compare | @dhmlau rebase done |
| @slnode test please |
| @zbarbuto @strongloop/sq-lb-apex , PTAL. |
| LGTM - I'm a bit out of the loop on it also, though. @raymondfeng comes to mind, maybe give it a quick once over and then should be able to merge? |
| Thank you for your contribution @sahilarora946. Taking a look. I'm wondering if we can simulate the behaviour that causes this issue in a test. |
| the PR LGTM, but I recommend adding a test which can simulate the scenario/bug we are fixing to avoid regressions in the future. @raymondfeng can you PTAL? |
| @b-admike sorry, i can't think of how we can simulate this behaviour. |
| Released as 3.3.2. |
6 participants
Description
This fixes the issue described in #230
Related issues
#129
Refer to rollback function in https://github.com/zbarbuto/loopback-connector-postgresql/blob/1361460cea86fadd14a68aa8fe9c55f14ecb9a6d/lib/transaction.js#L58-L86
After the
ROLLBACKis executed, callback will be sent to the event loop to be executed. Event loop can pick any of the available callbacks to execute. It can pick another function that can do database calls in the same transaction and because releaseConnection has not been called, the statement will execute.To stop the execution,
connection.txIdshould be set to null without waiting for the callback ofROLLBACKto be called