- Notifications
You must be signed in to change notification settings - Fork 182
Include the SSL Property #305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
Can one of the admins verify this patch? |
1 similar comment
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ataft Thank you for your contribution. I've left two comments which are not quite related to your PR, but would be great if you could fix them. If not, we could do them in a separate PR.
README.md Outdated
"host": "mydbhost", | ||
"port": 5432, | ||
"url": "postgres://admin:admin@myhost/db", | ||
"url": "postgres://admin:admin@myhost/db?ssl=false", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not related to your change, but could you add the port in the url
string and fix myhost
and db
to be mydbhost
and db1
respectively? Here is an example complete url
string:
const connectionString = 'postgresql://dbuser:secretpassword@database.server.com:3211/mydb'
README.md Outdated
"host": "mydbhost", | ||
"port": 5432, | ||
"url": "postgres://admin:admin@myhost/db", | ||
"url": "postgres://admin:admin@myhost/db?ssl=false", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto. Could you please fix up the url
string as I mentioned in my other comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please sign the CLA :-)
Fixes made and CLA signed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@slnode test please |
@ataft Please squash your commits into one with the commit message of your first commit, and we should be able to land. |
I can't figure out how to squash them. Can you just "Squash and Merge" when you do the merge? Thanks |
@ataft No worries, I have squashed them for you. Here are the commands I ran for your future reference:
If you want detailed logs for the commands, I've put them in a gist here. Thank you again for your contribution! 🎉 |
@slnode test please |
8 similar comments
@slnode test please |
@slnode test please |
@slnode test please |
@slnode test please |
@slnode test please |
@slnode test please |
@slnode test please |
@slnode test please |
82fd7b2
to 5f7a059
Compare @slnode test please |
Description
Related issues
Checklist
guide