DO NOT MERGE: Rebased and cleaned up version of #186 #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The tests are all run in the same process against the same instances of the module so care must be taken to not clobber things like the shared config that the tests all use. When the username is removed from the shared config then the pg attempts to use the OS username as the DB username. This is not guaranteed and is actually not true in the Windows environments these tests run under in CI.
| Closing this PR as it is not necessary. |
kjdelisle pushed a commit that referenced this pull request Mar 31, 2017
* Remove console.log (Raymond Feng) * Monkey patch generic-pool to work through errors (Russ Tyndall) * Fix the escape char (Raymond Feng) * Upgrade to loopback-connector@4.x (Loay) * Add checkFieldAndIndex for table status (#228) (Sakib Hasan) * Refactor migration methods (ssh24) * Fix code style inconsistencies in ilike tests (Alireza Ahmadi) * Improve tests for better code style consistency (Alireza Ahmadi) * Add tests for pattern matching operators (Alireza Ahmadi) * Add ILIKE functionality (Alireza Ahmadi) * Refactor discovery models (Loay Gewily) * merge in #216 (gregdingle) * Fix unit tests (ssh24) * Fix linting errors and unnesssary changes. (Diana Lau) * remove done() calls in test (gregdingle) * Added test. Ran run-tests. (gregdingle) * Fix bug where settings for pg-pool were dropped (Greg Dingle) * Update README with correct doc links, etc (Amir Jafarian) * Add test for bulk transactions (Zak Barbuto) * Use pg callback over connection.release (#109) (Zak Barbuto) * Use pool.pool.release over pool.release (#109) (Zak Barbuto) * Add test env information to README (Zak Barbuto) * update README for local postgres setup (Diana Lau) * Update postgresql.js (tmclouisluk) * Fix bug when using postgresql 8.x (tmclouisluk) * Replicate new issue_template from loopback (Siddhi Pai) * Replicate issue_template from loopback repo (Siddhi Pai) * Update LB connector version (Loay) * Use unique param for affectedRows (Loay) * Move info from docs into README (#199) (Rand McKinney) * Update paid support URL (Siddhi Pai) * Start 3.x + drop support for Node v0.10/v0.12 (siddhipai) * Drop support for Node v0.10 and v0.12 (Siddhi Pai) * Start the development of the next major version (Siddhi Pai)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Rebased and cleaned up version of #186 to show necessary changes for passing on CI.