Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
880d77a
Refactor: review/normalize (exception) logging
kares Mar 29, 2022
d315921
Refactor: code for improved readability
kares Mar 29, 2022
ce5a90c
Test: add some happy/error path tests
kares Mar 29, 2022
30ddbe7
a close operation should release client sockets
kares Mar 29, 2022
87afddc
Feat: ssl_supported_protocols option
kares Mar 30, 2022
dd4072f
Refactor: less noise on warnings
kares Mar 30, 2022
4490a22
Docs: copy-pasta for ssl_supported_protocols
kares Mar 30, 2022
33b61ae
jruby-openssl >= 0.12.2 dependency needed
kares Mar 30, 2022
7cae392
minor
kares Mar 30, 2022
63e7813
Test: unit test for ssl_supported_protocols
kares Mar 30, 2022
5909151
a note on the current limitation
kares Mar 30, 2022
3cca9ea
Test: JSON dependency
kares Mar 30, 2022
d391254
Test: let's just skip the test on 6.x
kares Mar 30, 2022
dbdf66d
Revert test container detection hack
kares Apr 18, 2022
3737657
bump + changelog
kares Apr 18, 2022
b2210b6
require latest LS 8.1 due jruby-openssl pinning
kares Apr 28, 2022
0c94ec0
redundant docs related to Java 8
kares Apr 28, 2022
0d68ece
one only
kares Apr 28, 2022
53e138d
Update lib/logstash/outputs/tcp.rb
kares May 5, 2022
d5b7dc3
remove limitation on setting only ranges
kares May 5, 2022
1193e63
might happen multiple times
kares May 5, 2022
c063e2e
close em all!
kares May 5, 2022
051ae4c
Refactor: logging helpers to do ~ same
kares May 5, 2022
69115c2
(more) thread-safe closing of client threads
kares May 5, 2022
b775674
nonblock accept - to not be waiting while closing
kares May 5, 2022
7b4d61f
a bit of thead naming convention - yay!
kares May 5, 2022
c4f1628
Update lib/logstash/outputs/tcp.rb
kares May 9, 2022
656a9af
restore filtering out dead threads from i-var
kares May 9, 2022
5481865
Review: use pipeline_id when naming threads
kares May 9, 2022
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update lib/logstash/outputs/tcp.rb
Co-authored-by: João Duarte <jsvd@users.noreply.github.com>
  • Loading branch information
kares and jsvd authored May 5, 2022
commit 53e138d91a0cad9c5edb34206bbd852f3792a58b
8 changes: 3 additions & 5 deletions lib/logstash/outputs/tcp.rb
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,9 @@ def write(msg)
end # def write

def close
begin
@socket.close
rescue => e
log_warn 'socket close failed:', e, socket: (@socket ? @socket.to_s : nil)
end
@socket.close
rescue => e
log_warn 'socket close failed:', e, socket: (@socket ? @socket.to_s : nil)
end
end # class Client

Expand Down