Skip to content

Fix: unable to start with password protected key #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 21, 2022
Merged

Fix: unable to start with password protected key #45

merged 2 commits into from
Mar 21, 2022

Conversation

kares
Copy link
Contributor

@kares kares commented Mar 21, 2022

by not using the passphrase.value we always passed an object who's to_s returned '<password>'
@kares kares requested a review from kaisecheng March 21, 2022 08:49
@kares kares linked an issue Mar 21, 2022 that may be closed by this pull request
Pipeline error "Neither PUB key nor PRIV key" when using encrypted key #46
Closed
kaisecheng
kaisecheng approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@kaisecheng kaisecheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@kares kares merged commit 2f73981 into logstash-plugins:main Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@kares @kaisecheng @roaksoax