Fix a synchronization issue when in the `#teardown #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Multiple threads were accessing the tempfile when we were trying to shutdown the pipeline. This issues was the cause of a non deterministic test for testing the file rotation. Fixes #23
Contributor Author
There was a problem hiding this comment.
This initialization wasn't need to actually test the move_file_to_bucket.
Contributor Author
| @purbon The spec added to test the synchronization issue when doing a file rotation wasn't shutting down the pipeline cleanly. I have discovered that the |
Contributor Author
| Would you mind reviewing this? |
Contributor Author
| @purbon I have fixed the failling test, can you review the changes? |
| @ph code looks good to me. If I understand the issue properly, test are supposed to catch also the synchronization issue now, right? |
Contributor Author
| Yes they are catching it, I did a 100 iterations run and I did not get any more error. |
| ++ go for it LGTM |
| Merged sucessfully into master! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Multiple threads were accessing the tempfile when we were trying to
shutdown the pipeline. This issues was the cause of a non deterministic
test for testing the file rotation.
Fixes #23