Tolerate the elasticsearch-ruby v8 client in integration tests. #1208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ses it in integration tests. This change tolerates the elasticsearch-ruby v8 client.
fix tests to not require custom es ruby code
…ources easily in the future.
jsvd reviewed Mar 21, 2025
jsvd approved these changes Mar 21, 2025
jsvd added a commit to jsvd/logstash-output-elasticsearch that referenced this pull request Aug 1, 2025
…tash-plugins#1208) * elasticsearch-ruby client got updated to v8 in LS core. This plugin uses it in integration tests. This change tolerates both elasticsearch-ruby v7 and v8 client versions. * Fix the ILM spec issue where method was removed, restored internally. --------- Co-authored-by: João Duarte <jsvduarte@gmail.com>
jsvd added a commit that referenced this pull request Aug 1, 2025
…fixes) (#1219) Adds two new headers to each bulk request: * "X-Elastic-Event-Count": number of actions / documents in that bulk request * "X-Elastic-Uncompressed-Request-Length": size in bytes of the request body before compression X-Elastic-Uncompressed-Request-Length is equal to Content-Length when compression is disabled. Backport fixes: * Tolerate the elasticsearch-ruby v8 client in integration tests. (#1208) * elasticsearch-ruby client got updated to v8 in LS core. This plugin uses it in integration tests. This change tolerates both elasticsearch-ruby v7 and v8 client versions. * Fix the ILM spec issue where method was removed, restored internally. Co-authored-by: Mashhur <99575341+mashhurs@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Recently LS core upgraded elasticsearch-ruby client to v8. This plugin uses it in integration tests and recent failures show due to es-ruby client upgrade: https://github.com/logstash-plugins/logstash-output-elasticsearch/pull/1207/checks?check_run_id=39057545885
This change tolerates elasticsearch-ruby both v7 and v8 clients.