Remove unused absolete TLS params. #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mashhurs commented May 23, 2023
| | ||
| # TLS certificate password | ||
| config :tls_certificate_password, :validate => :string, :obsolete => "This setting is obsolete. Use ssl_certificate_password instead" | ||
| config :tls_certificate_password, :validate => :password, :obsolete => "This setting is obsolete. Use ssl_certificate_password instead" |
There was a problem hiding this comment.
Can we even remove tls_certificate_path and tls_certificate_password? They are not used in the source at all, replaced by ssl_certificate_path and ssl_certificate_password.
There was a problem hiding this comment.
Yes, lets remove them since they are obsolete now.
mashhurs changed the title …rams since they are not used at all.
| lgtm! |
roaksoax approved these changes May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When using config debug option,tls_certificate_passwordvalue can be seen in the logs.This PR intends to change
tls_certificate_passwordtype topasswordto protect from leaks in the logs.After investigation, it was clear that
tls_certificate_passwordandtls_certificate_passwordare not used at all, absolote. Thus, decided to remove them.tls_certificate_passwordconfig is leaked in debug logs. #53