remove logstash/pipeline #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
14 tasks
andsel reviewed Dec 22, 2020
.ci/common/logstash.Dockerfile Outdated
| COPY --chown=logstash:logstash *.gemspec VERSION* version* /usr/share/plugins/plugin/ | ||
| RUN cp /usr/share/logstash/logstash-core/versions-gem-copy.yml /usr/share/logstash/versions.yml | ||
| ENV PATH="${PATH}:/usr/share/logstash/vendor/jruby/bin" | ||
| # NOTE: since 8.0 JDK is bundled as part of the LS distribution under $LS_HOME/jdk |
There was a problem hiding this comment.
It's from 7.10 that's bundled in the distribution
There was a problem hiding this comment.
it is copied from .ci/Dockerfile I can change it to 7.10
| | ||
| echo "Testing against version: $ELASTIC_STACK_VERSION" | ||
| | ||
| if [[ "$ELASTIC_STACK_VERSION" = *"-SNAPSHOT" ]]; then |
There was a problem hiding this comment.
I've not a such a deep knowledge of docker, but docker pull is the same as this curl + docker load ?
There was a problem hiding this comment.
docker pull pull the image from the registry while docker load import image from STDIN .tar.gz
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixed: elastic/logstash#11236
This PR replace remove ruby pipeline