Fix: unable to stop plugin (on older versions of LS) #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Closed
kares changed the title 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Plugin has been failing CI for a long time on 6.x for a long time.
The problematic spec assumes a client socket blocking from
readpartial(while the server keep the socket open wout writing anything) to be interruptible onclient_socket.close- this is not the case and the only reason the spec does not hang CI is due the teardown closing the server socket -> leads to a EOF from thereadpartial.Seems this has been "broken" on JRuby 9.2.7.0 (LS 6.8.x) and closing a socket stuck in
readpartialhangs.The failure aksi revealed a deeper (timeout) issue in terms of how the plugin works.
The potential use of
timeoutis problematic - a proper implementation would be to useselectwith a timeout and check for stopping periodically.