Implement plugin stop behavior

[andrewvc]

Implement stop behavior for #3

[ph]

it should be ~> 2.0.0.snapshot

So it will pick the latest release of the snapshot.

[andrewvc]

I can't get the tests to pass with this setting. Can you?

[andrewvc]

To clarify it won't get gems from github or work with an explicit :path in my Gemfile for me.

[ph]

You don't need to have a :path defined, because the devutils and the logstash-core gems exist on rubygems.

[ph]

~/e/l/logstash-input-sqlite git:pr/4 ❯❯❯ rm *.lock ⏎ ✱ ◼ ~/e/l/logstash-input-sqlite git:pr/4 ❯❯❯ bundle install ✱ ◼ Fetching gem metadata from https://rubygems.org/.......... Fetching version metadata from https://rubygems.org/... Fetching dependency metadata from https://rubygems.org/.. Resolving dependencies..... Using rake 10.4.2 Using cabin 0.7.1 Using clamp 0.6.5 Using coderay 1.1.0 Using concurrent-ruby 0.9.1 Using diff-lcs 1.2.5 Using ffi 1.9.10 Using filesize 0.0.4 Using gem_publisher 1.5.0 Using gems 0.8.3 Using i18n 0.6.9 Using insist 1.0.0 Using jdbc-sqlite3 3.8.10.1 Using jrjackson 0.2.9 Using kramdown 1.8.0 Using minitar 0.5.4 Using method_source 0.8.2 Using slop 3.6.0 Using spoon 0.0.4 Using pry 0.10.1 Using stud 0.0.22 Using thread_safe 0.3.5 Using polyglot 0.3.5 Using treetop 1.4.15 Using logstash-core 2.0.0.snapshot2 Using logstash-codec-plain 1.0.0 Using rspec-support 3.1.2 Using rspec-core 3.1.7 Using rspec-expectations 3.1.2 Using rspec-mocks 3.1.3 Using rspec 3.1.0 Using rspec-wait 0.0.7 Using logstash-devutils 0.0.16 Using sequel 4.26.0 Using logstash-input-sqlite 2.0.0 from source at . Using bundler 1.10.6 Bundle complete! 3 Gemfile dependencies, 36 gems now installed. Use `bundle show [gemname]` to see where a bundled gem is installed. 

[ph]

This was run with this gemspec with the right constrains

Gem::Specification.new do |s| s.name = 'logstash-input-sqlite' s.version = '2.0.0' s.licenses = ['Apache License (2.0)'] s.summary = "Read rows from an sqlite database." s.description = "This gem is a logstash plugin required to be installed on top of the Logstash core pipeline using $LS_HOME/bin/plugin install gemname. This gem is not a stand-alone program" s.authors = ["Elastic"] s.email = 'info@elastic.co' s.homepage = "http://www.elastic.co/guide/en/logstash/current/index.html" s.require_paths = ["lib"] # Files s.files = Dir['lib/**/*','spec/**/*','vendor/**/*','*.gemspec','*.md','CONTRIBUTORS','Gemfile','LICENSE','NOTICE.TXT'] # Tests s.test_files = s.files.grep(%r{^(test|spec|features)/}) # Special flag to let us know this is actually a logstash plugin s.metadata = { "logstash_plugin" => "true", "logstash_group" => "input" } # Gem dependencies s.add_runtime_dependency "logstash-core", "~> 2.0.0.snapshot" s.add_runtime_dependency 'sequel' s.add_runtime_dependency 'jdbc-sqlite3' s.add_development_dependency 'logstash-devutils' s.add_development_dependency 'logstash-codec-plain' end

[ph]

The tests are running but I have added really minor comment, once you fixed them you can merge.

[elasticsearch-bot]

Merged sucessfully into master!