handle plugin and spec execution on windows #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
lib/logstash/inputs/pipe.rb Outdated
There was a problem hiding this comment.
Please choose between doesn't and does not ;)
Closed
spec/inputs/pipe_spec.rb Outdated
There was a problem hiding this comment.
Would it be better to tag the suite with unix and exclude it when running the test? We could use the same behavior for windows only plugins.
There was a problem hiding this comment.
done, depends on elastic/logstash-devutils#19
| LGTM, but did not test in real live. BTW @jsvd what about a minor version bump? |
| LGTM, just bump and release it. |
| Merged sucessfully into master! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This patch skips the test suite when started from Windows, and raises an Exception if the plugin is used on Windows.