docs: in-place removal of source block macros to fix docs build #2
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Release notes
[rn:skip]
What does this PR do?
Fixes the docs build.
TIL that
[source]blocks are handled as subdocuments in asciidoc, and their ability to link to the outer doc that contains them is implementation-specific. While my local docs tools can resolve the references, the docs build was broken by them 😩Why is it important/What is the impact to the user?
It removes a broken thing from the docs used by the combined LS docs build.
We will need to mutate the tag held in github for the versioned plugin reference to pick up this fix since it is sourcing from rubygems version number (which is less than ideal), but with net zero code changes on this pre-1.0 project I am comfortable with the ramifications.
Once merged, we will need to push a tag deletion to github:
And then this will need to be re-tagged (preferably including a cryptographic signature).