Add basic github action for regression testing #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
whummer approved these changes Dec 28, 2023
Member
There was a problem hiding this comment.
Awesome, great to see this covered by some basic smoke/regression tests @dominikschubert ! 🚀 Nice idea with the multi-account testing for 000000000001 as well 👌
| which aws | ||
| which awslocal | ||
| | ||
| - name: Start and wait for localstack (Community) |
Member
There was a problem hiding this comment.
nit: At some point in the future we could start dogfooding our own Github Action.. https://github.com/localstack/setup-localstack 😎 (no need to change for now, though..)
alexrashed approved these changes Jan 2, 2024
Member
alexrashed left a comment
alexrashed left a comment There was a problem hiding this comment.
Thanks a lot! These tests were long overdue! 🥇 💯
Member Author
| Thanks @alexrashed for pointing out that this is still open 😅 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Adds a basic GitHub action regression test to verify that basic awslocal commands are still working.
Can be extended with multiple other cases as well like:
awslocal ...service calls