Skip to content

Conversation

@simonecorsi
Copy link

Hi! 👋

Thank for this plugin, I've been using it but I'm working under a older version of Gitlab so sometimes we're missing some feature.

This PR brings duration field to Gitlab version under v15, since fields updated_at and created_at doesn't exists on the /pipelines endpoint.

I was thinking we could also use the /version endpoint to get the gitlab version at the start of this plugin so we could use it later on subsequent calls to avoid wasting bandwidth, WDYT?

Before
Screenshot 2022-06-01 at 16 06 00

After
Screenshot 2022-06-01 at 16 06 07

To be compatible with all Gitlab version uses complete pipeline object Signed-off-by: Simone Corsi <simonecorsi.dev@gmail.com>
@simonecorsi simonecorsi force-pushed the feat/cross-version-pipeline-infos branch from b02282b to f1a63cd Compare June 1, 2022 14:14
@satrox28
Copy link
Collaborator

Hi @simonecorsi ,

Thanks for raising the PR, can you provide me your gitlab version where you are noticing this issue?.

@simonecorsi
Copy link
Author

simonecorsi commented Jun 21, 2022

Hey @satrox28!

Thanks for getting back to me on this, for security policies I can't disclose our self-hosted version in public, but you can pvt me on twitter if you want to discuss this, my handle is im_simonecorsi 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants