[MLIR][Presburger] Fraction: implement arithmetic operations (/, +, -) and printing #65310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Superty requested changes Sep 5, 2023
Member
Superty left a comment
Superty left a comment There was a problem hiding this comment.
It would be great if you could also add +=, -= which are also used in Matrix, so that doesn't have to be changed over there.
Contributor Author
Done! |
Superty reviewed Sep 5, 2023
Superty reviewed Sep 5, 2023
Superty reviewed Sep 5, 2023
Superty reviewed Sep 5, 2023
Superty changed the title avillega pushed a commit to avillega/llvm-project that referenced this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.