- Notifications
You must be signed in to change notification settings - Fork 15.2k
[LifetimeSafety] Implement multi-level origins #168344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
You can test this locally with the following command:git-clang-format --diff origin/main HEAD --extensions cpp,h -- clang/include/clang/Analysis/Analyses/LifetimeSafety/Facts.h clang/include/clang/Analysis/Analyses/LifetimeSafety/FactsGenerator.h clang/include/clang/Analysis/Analyses/LifetimeSafety/LifetimeAnnotations.h clang/include/clang/Analysis/Analyses/LifetimeSafety/Origins.h clang/lib/Analysis/LifetimeSafety/Facts.cpp clang/lib/Analysis/LifetimeSafety/FactsGenerator.cpp clang/lib/Analysis/LifetimeSafety/LifetimeAnnotations.cpp clang/lib/Analysis/LifetimeSafety/LiveOrigins.cpp clang/lib/Analysis/LifetimeSafety/LoanPropagation.cpp clang/lib/Analysis/LifetimeSafety/Origins.cpp clang/lib/Sema/CheckExprLifetime.cpp clang/lib/Sema/CheckExprLifetime.h clang/lib/Sema/SemaAttr.cpp clang/test/Sema/warn-lifetime-safety.cpp clang/unittests/Analysis/LifetimeSafetyTest.cpp --diff_from_common_commit
View the diff from clang-format here.diff --git a/clang/lib/Analysis/LifetimeSafety/Origins.cpp b/clang/lib/Analysis/LifetimeSafety/Origins.cpp index a72e2e5e2..e9b07e985 100644 --- a/clang/lib/Analysis/LifetimeSafety/Origins.cpp +++ b/clang/lib/Analysis/LifetimeSafety/Origins.cpp @@ -7,11 +7,11 @@ //===----------------------------------------------------------------------===// #include "clang/Analysis/Analyses/LifetimeSafety/Origins.h" -#include "clang/Analysis/Analyses/LifetimeSafety/LifetimeAnnotations.h" #include "clang/AST/ASTContext.h" #include "clang/AST/Attr.h" #include "clang/AST/DeclCXX.h" #include "clang/AST/DeclTemplate.h" +#include "clang/Analysis/Analyses/LifetimeSafety/LifetimeAnnotations.h" namespace clang::lifetimes::internal { @@ -38,7 +38,8 @@ void OriginManager::dump(OriginID OID, llvm::raw_ostream &OS) const { template <typename T> OriginTree *OriginManager::buildTreeForType(QualType QT, const T *Node) { - assert(isPointerLikeType(QT) && "buildTreeForType called for non-pointer type"); + assert(isPointerLikeType(QT) && + "buildTreeForType called for non-pointer type"); OriginTree *Root = createNode(createOrigin(Node)); if (QT->isPointerOrReferenceType()) { QualType PointeeTy = QT->getPointeeType(); diff --git a/clang/unittests/Analysis/LifetimeSafetyTest.cpp b/clang/unittests/Analysis/LifetimeSafetyTest.cpp index b63ddbb73..2268e4164 100644 --- a/clang/unittests/Analysis/LifetimeSafetyTest.cpp +++ b/clang/unittests/Analysis/LifetimeSafetyTest.cpp @@ -101,7 +101,8 @@ public: // This assumes the OriginManager's `get` can find an existing origin. // We might need a `find` method on OriginManager to avoid `getOrCreate` // logic in a const-query context if that becomes an issue. - // return const_cast<OriginManager &>(Analysis.getFactManager().getOriginMgr()) + // return const_cast<OriginManager + // &>(Analysis.getFactManager().getOriginMgr()) // .get(*VD); return std::nullopt; } |
9b403b6 to 43233fe Compare 🐧 Linux x64 Test Results
Failed Tests(click on a test name to see its output) ClangClang.Sema/warn-lifetime-safety-dataflow.cppClang-UnitClang-Unit._/AllClangUnitTests/LifetimeAnalysisTest/AssignInSwitchClang-Unit._/AllClangUnitTests/LifetimeAnalysisTest/ConditionalLoanClang-Unit._/AllClangUnitTests/LifetimeAnalysisTest/ExtraParenthesisClang-Unit._/AllClangUnitTests/LifetimeAnalysisTest/GslPointerConstructFromOwnerClang-Unit._/AllClangUnitTests/LifetimeAnalysisTest/GslPointerConstructFromViewClang-Unit._/AllClangUnitTests/LifetimeAnalysisTest/GslPointerConversionOperatorClang-Unit._/AllClangUnitTests/LifetimeAnalysisTest/GslPointerInConditionalOperatorClang-Unit._/AllClangUnitTests/LifetimeAnalysisTest/GslPointerPropagationClang-Unit._/AllClangUnitTests/LifetimeAnalysisTest/GslPointerReassignmentClang-Unit._/AllClangUnitTests/LifetimeAnalysisTest/GslPointerSimpleLoanClang-Unit._/AllClangUnitTests/LifetimeAnalysisTest/GslPointerWithConstAndAutoClang-Unit._/AllClangUnitTests/LifetimeAnalysisTest/InfiniteLoopPrunesEdgesClang-Unit._/AllClangUnitTests/LifetimeAnalysisTest/LifetimeboundChainOfViewsClang-Unit._/AllClangUnitTests/LifetimeAnalysisTest/LifetimeboundConstRefObjParamClang-Unit._/AllClangUnitTests/LifetimeAnalysisTest/LifetimeboundConstRefViewParameterClang-Unit._/AllClangUnitTests/LifetimeAnalysisTest/LifetimeboundConversionOperatorClang-Unit._/AllClangUnitTests/LifetimeAnalysisTest/LifetimeboundMemberFunctionClang-Unit._/AllClangUnitTests/LifetimeAnalysisTest/LifetimeboundMixedArgsClang-Unit._/AllClangUnitTests/LifetimeAnalysisTest/LifetimeboundMultipleArgsClang-Unit._/AllClangUnitTests/LifetimeAnalysisTest/LifetimeboundRawPointerParameterClang-Unit._/AllClangUnitTests/LifetimeAnalysisTest/LifetimeboundReturnReferenceClang-Unit._/AllClangUnitTests/LifetimeAnalysisTest/LifetimeboundSimpleClang-Unit._/AllClangUnitTests/LifetimeAnalysisTest/LifetimeboundTemplateClassClang-Unit._/AllClangUnitTests/LifetimeAnalysisTest/LifetimeboundTemplateFunctionClang-Unit._/AllClangUnitTests/LifetimeAnalysisTest/LivenessAcrossBranchesClang-Unit._/AllClangUnitTests/LifetimeAnalysisTest/LivenessInLoopClang-Unit._/AllClangUnitTests/LifetimeAnalysisTest/LivenessInLoopAndIfClang-Unit._/AllClangUnitTests/LifetimeAnalysisTest/LivenessInLoopAndIf2Clang-Unit._/AllClangUnitTests/LifetimeAnalysisTest/LivenessKilledByReassignmentClang-Unit._/AllClangUnitTests/LifetimeAnalysisTest/LivenessOutsideLoopClang-Unit._/AllClangUnitTests/LifetimeAnalysisTest/LivenessSimpleReturnClang-Unit._/AllClangUnitTests/LifetimeAnalysisTest/LoopWithBreakClang-Unit._/AllClangUnitTests/LifetimeAnalysisTest/NestedScopesClang-Unit._/AllClangUnitTests/LifetimeAnalysisTest/OverwriteOriginClang-Unit._/AllClangUnitTests/LifetimeAnalysisTest/PointerChainClang-Unit._/AllClangUnitTests/LifetimeAnalysisTest/PointersAndExpirationInACycleClang-Unit._/AllClangUnitTests/LifetimeAnalysisTest/PointersInACycleClang-Unit._/AllClangUnitTests/LifetimeAnalysisTest/ReassignInIfClang-Unit._/AllClangUnitTests/LifetimeAnalysisTest/ReassignToNullClang-Unit._/AllClangUnitTests/LifetimeAnalysisTest/SimpleLoanAndOriginClang-Unit._/AllClangUnitTests/LifetimeAnalysisTest/ViewFromTemporaryIf these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the |
43233fe to 28ba2e1 Compare 28ba2e1 to e0f4136 Compare 
No description provided.